Add PHP 8 and Symfony 5.2 support. #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
welcoMattic
reviewed
Jun 1, 2021
|
Great job ! I was waiting that for so long |
|
@ylcdx Did you make real tests against the Phrase API? |
yes, but not directly by I think it would have been easier to implement a Translation Providers for Phrase directly (symfony/symfony#38475) ;) |
|
Hm, I see we have Travis config file in this repo but I don't see any Travis checks in this PR - only failed Scrutinizer. Probably Travis isn't activated for this repo? |
|
@ylcdx Yes, I think it is. If you want to start/do it, feel free to contact me on Symfony Devs Slack it you need help 👍 |
|
@bocharsky-bw We should move from Travis.org as it will be shutdown in the 15th of June |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12